Return HTTP 403 instead of 500 on NoInstancesException#1643
Open
FurriousFox wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1643 +/- ##
============================================
- Coverage 97.26% 97.24% -0.03%
- Complexity 2845 2846 +1
============================================
Files 175 175
Lines 8887 8889 +2
============================================
Hits 8644 8644
- Misses 243 245 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially mitigates issues caused by sabre/dav not accepting recurrence events without any instances (which technically doesn't satisfy RFC 5545, but is an understandable compromise).
This fix is essentially equal to the fix applied in Nextcloud nextcloud/server#46593
Concerns with HTTP 500 are best explained by nextcloud/server#30514 (comment)